Lab 4

Introduction
    This weeks lab was fairly frustrating, I am not sure if it was all the environmental stressors around me this week, or if it was since I had never worked with a git remote before. Nonetheless, the work has been completed. Heres a little gif to let you know how I felt.

Picking and Filing an Issue

    For this weeks lab, I choose to work on an old friends repository. Im not sure if this is considered cheating, however, I gave my friend a call to run me through how his code works. In five minutes, I had a basic understanding of his work, and was left to study his code. Since it was not my own code, I had some difficulty reading it. I created a new branch, and started cleaning up the repository to better fit my needs.

    I created a pull request simplifying the code, however, no merge was done. I guess everyone has their own preference of how their code should look. After failing the first time, I decided to try again by creating an issue on his repository, starting a new branch, and getting to work!

Here is Niaz's Repository : https://github.com/Niaz-Ul-Haque/nlinks
Here is The First Pull Request : Cleaning Console Logs

Creating and Working on Topic Branch

    Since this repository was not the same logic as mine, I instantly knew that this repository needed some critical thinking. Niaz's structured his command line interface to have his "--good", "--bad", and "--all" optionality as the third parameter. This made things a little tricky. I had to think of a logical way to integrate my logic without jeopardizing his. 

Creating an issue on repository: https://github.com/Niaz-Ul-Haque/nlinks/issues/16

Completing the Feature

    After completing the issue at hand I created a merge request and asked Niaz to check out my repository before merging. However, Niaz seemed to not realize lab four asks us to test the pull request before merging. He just merged the pull request trusting in my abilities. As much as I was flattered by his gesture, it reminded me of a quote from the movie Chernobyl, "Trust, but verify".

    This is when everything burst into flames. I thought I finished the feature! I checked the next day only to discover that I broke his logic. This was a blessing in disguise since this allowed Niaz to learn to verify every merge before he implements it. I quickly fixed the logic and pushed a new merge. Now I'm not sure if Niaz will read my message before merging, however, he now has the chance to checkout my branch before merging.


Here is The Main Pull Request :Ignore Urls PR
Here is The Main Pull Request Fixed : Sorry Niaz
This is The Last Pull Request Updating ReadMe

Reviewing, Testing, and Merge via Remotes

I have yet to get Niaz's Pull request. I will update this later this week.
Thanks for reading my blog post.

Image for post





Comments

Post a Comment

Popular posts from this blog

Working with others

     This week our course was given the task of creating a cli command, which included our code being reviewed by one of my classmates. Initially, this gave me some anxiety as sharing my work with others is not my strongest suit. Nonetheless, I created a post asking if anyone was looking for a partner and Michael Appeared.      It turns out that having someone look over my work was much less scary than I had initially anticipated. Working with Michael was actually fun, and having the opportunity to look over someone else's work was a great learning experience for me.       With another pair of eyes looking at my code, Michael noticed errors and instructions that I was not addressing. Some instructions I had forgot to mention include the fact that my program requires bash. It did not occur to me that most of us live in a Windows Operating System. Another missing component was my Blog link in my READme. I had forgotten to include a link to...
Read more

Release V0.3 Part 2

Internal Project Contribution In the past and currently, I have worked on several issues within the Telescope community. At first I was worried about understanding other peoples code. However, after looking at a few issues and spending some time on Telescopes repository, I noticed that I could contribute to some of the issues that our community was facing. In total, I worked on three different issues all ranging from different skill levels, the easiest being the documentation update. You can check out the changes that were implemented here . In order to update the documentation, I had to read up on all the different types of logging. I excluded the unnecessary information from Telescopes documentation to accentuate the important details about how to implement the logger. The documentation update got merged fairly quickly, this gave me a sense of relief since I was worried that I would not be able to get a commit in before the due date. Completing the required pull requests for Rel...
Read more

Paving the Way

Sorry my blog hasn't been updating recently, Im so busy getting ready to get in the groove back at home. Im not going to lie the vacation life is great! Waking up at 3pm, taking baths, and the food is ready when I sit down at the table. It's a privilege I take for granted.  Since writing a blog post helps me take a minute to reflect on the experiences I have been going through, I will keep making these blog posts. In addition, I noticed these blog posts encourage me to acknowledge the accomplishments of today, keep me focused on the progress I am making, and finally.. I must work on articulating sentences. Here is a visualization of myself:  An update on what I have been doing. I moved back home for Christmas, I started working on my pool hall app, and Ive been applying to positions. With Christmas break upon us I would like to get some personal projects going. This will give me the opportunity to solidify my knowledge of what I have learned so far. I started working on this p...
Read more